mm: make page ref count overflow check tighter and more explicit
authorLinus Torvalds <torvalds@linux-foundation.org>
Thu, 11 Apr 2019 17:06:20 +0000 (10:06 -0700)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 15 May 2019 22:07:16 +0000 (23:07 +0100)
commit7d04240f708362021999f92bdf483cd9ed1db222
tree3865f96fdb531713eb7b46e14e85b0d7dc6023bf
parent9f8c3b7a3e97f6fe2fcb045b32ef5616e598153c
mm: make page ref count overflow check tighter and more explicit

commit f958d7b528b1b40c44cfda5eabe2d82760d868c3 upstream.

We have a VM_BUG_ON() to check that the page reference count doesn't
underflow (or get close to overflow) by checking the sign of the count.

That's all fine, but we actually want to allow people to use a "get page
ref unless it's already very high" helper function, and we want that one
to use the sign of the page ref (without triggering this VM_BUG_ON).

Change the VM_BUG_ON to only check for small underflows (or _very_ close
to overflowing), and ignore overflows which have strayed into negative
territory.

Acked-by: Matthew Wilcox <willy@infradead.org>
Cc: Jann Horn <jannh@google.com>
Cc: stable@kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gbp-Pq: Topic bugfix/all
Gbp-Pq: Name 0001-mm-make-page-ref-count-overflow-check-tighter-and-mo.patch
include/linux/mm.h